[PATCH] md/raid10: get rid of duplicated conditional expression

Variable 'first' is initialized to zero and updated to [at] rdev->raid_disk
only if it is greater than 0. Thus condition '>= first' always implies
'>= 0' so the latter is not needed.

Signed-off-by: Namhyung Kim <namhyung [at] gmail.com>
---
drivers/md/raid10.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index fc56bdd8c3fb..fcb86e86bc31 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
[at] [at] -1093,8 +1093,7 [at] [at] static int raid10_add_disk(mddev_t *mddev, mdk_rdev_t *rdev)
if (rdev->raid_disk >= 0)
first = last = rdev->raid_disk;

- if (rdev->saved_raid_disk >= 0 &&
- rdev->saved_raid_disk >= first &&
+ if (rdev->saved_raid_disk >= first &&
conf->mirrors[rdev->saved_raid_disk].rdev == NULL)
mirror = rdev->saved_raid_disk;
else
--
1.7.5.2

--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo [at] vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Namhyung Kim [ Mi, 08 Juni 2011 13:35 ] [ ID #2060675 ]
Linux » gmane.linux.raid » [PATCH] md/raid10: get rid of duplicated conditional expression

Vorheriges Thema: (unknown)
Nächstes Thema: [PATCH] md/raid10: optimize read_balance() for 'far offset' arrays